adds guest manager interfaces + implementation for guest operations #2598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
feat/vm-package-guestmanager
branch
from
76df85b to
3807b37
Compare
jterry75
reviewed
Feb 11, 2026
|
|
||
| // LayersManager exposes combined layer operations in the guest. | ||
| type LayersManager interface { | ||
| AddCombinedLayers(ctx context.Context, settings interface{}) error |
Contributor
There was a problem hiding this comment.
Why do you need combine and combine wcow? What is different?
Contributor
There was a problem hiding this comment.
Oh its C WCOW. I get it. This isn't lcow/wcow difference its confidential vs not.
Contributor
There was a problem hiding this comment.
Does it have to be C 'W' COW? Or can it just be CombineConfidentialLayers() ? Is there something special here from the guest request perspective?
jterry75
reviewed
Feb 11, 2026
| ) | ||
|
|
||
| // BlockCIMsManager returns the guest block CIMs manager. | ||
| func (gm *guestManager) BlockCIMsManager() vm.BlockCIMsManager { |
Contributor
There was a problem hiding this comment.
If you have managers why dont they have the fn's that relate to what they do?
vm.BlockCIMManager().AddBlockCIM(settings) ?
vm.AddBlockCIM(settings) is what we have today. What is the point of the manager then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new guest-side management layer for virtual machines (VMs), clearly separating guest operations from host-side management and configuration. It does so by defining new interfaces and concrete implementations for interacting with the guest via the Guest Compute Service (GCS).
Note This PR is dependent upon #2597
The most important changes are:
Guest Manager Interface and Implementation:
GuestOpsinterface ininternal/vm/guest.go, which defines APIs for establishing a GCS connection and performing guest-side operations (network, storage, device, security policy, etc.). This interface is the contract for guest management.guestManagerimplementation ofGuestOpsininternal/vm/guestmanager/hcs.go, which manages the GCS connection lifecycle, applies configuration options, and exposes guest-side management interfaces.Guest Resource Management Implementations:
GuestNetworkManager) ininternal/vm/guestmanager/network.goDirectoryManager) ininternal/vm/guestmanager/mapped_directory.goLayersManager) ininternal/vm/guestmanager/combinedlayers.goGuestDeviceManager) ininternal/vm/guestmanager/device.goBlockCIMsManager) ininternal/vm/guestmanager/block_cims.goThis refactor lays a foundation for clean separation between host and guest responsibilities.